Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pattern for VPC CNI native network policy support #1781

Merged

Conversation

valentinwidmer
Copy link
Contributor

Description

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

  • Tested in a fresh AWS Account

@valentinwidmer valentinwidmer requested a review from a team as a code owner October 4, 2023 09:25
@valentinwidmer valentinwidmer temporarily deployed to EKS Blueprints Test October 4, 2023 09:25 — with GitHub Actions Inactive
@valentinwidmer valentinwidmer changed the title #1747 Add pattern for native network policy support docs: Add pattern for native network policy support Oct 4, 2023
@rodrigobersa
Copy link
Contributor

Hi @valentinwidmer!

Thanks for the PR. I’ll review and get back to you soon.

@rodrigobersa rodrigobersa temporarily deployed to EKS Blueprints Test October 10, 2023 02:03 — with GitHub Actions Inactive
@rodrigobersa rodrigobersa changed the title docs: Add pattern for native network policy support feat: Add pattern for native network policy support Oct 10, 2023
@rodrigobersa rodrigobersa changed the title feat: Add pattern for native network policy support feat: Add pattern for VPC CNI native network policy support Oct 10, 2023
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @valentinwidmer!!

Please update the docs/patterns using the same standards of the other patterns here.

Also, run the pre-commit scripts against your files to fix any formatting and lint for the CI tests. pre-commit run --files ./patterns/aws-vpc-cni-network-policy/*

@valentinwidmer valentinwidmer temporarily deployed to EKS Blueprints Test October 10, 2023 06:34 — with GitHub Actions Inactive
@valentinwidmer
Copy link
Contributor Author

Thank you @valentinwidmer!!

Please update the docs/patterns using the same standards of the other patterns here.

Also, run the pre-commit scripts against your files to fix any formatting and lint for the CI tests. pre-commit run --files ./patterns/aws-vpc-cni-network-policy/*

Added documentation and executed pre-commit scripts

Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rodrigobersa rodrigobersa merged commit e86d55a into aws-ia:main Oct 10, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for Amazon VPC CNI Network Policy feature
2 participants